Hi...
> PPS: Our DEBUG kernel recently had the wrong format string when showing
> the max-cylinder (clipped to 1023) of a disk. Not sure if it got fixed.
If somebody has been wondering, this is the offending code in
STATIC int LBA_Get_Drive_Parameters(int drive, struct DriveParamS *driveParam)
...
DebugPrintf(("drive parameters %02x - %04lu-%u-%u",
drive,
driveParam->chs.Cylinder,
driveParam->chs.Head, driveParam->chs.Sector));
The %04lu is wrong, as chs.Cylinder is a 16bit value (at most 1023).
PS: PLEASE shorten the fnode related debug messages! It is not
okay to have four lines of them for each single file that is
touched by a simple DIR. Four strings are okay, though, but not
all of those strings may contain line breaks at the end. Plus
a GENERAL request: Keep debug messages short. They do not have
to mention the full function name. A short unique string is enough
to find the source of the debug message in the source code files.
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel
