Hi! 28-Июл-2006 15:36 [EMAIL PROTECTED] (Japheth) wrote to freedos-devel@lists.sourceforge.net:
> 1. Bug: wrong handling for clc/stc in some places (they ignored, because > popf follows, thus caller receives "always success"): > @@loc2: > clc ; flag success > popf J> Interesting! Have you examined what implications this bug may have to an J> application? No. This report is result of pure context-less careful source reading (in some places). >> 2. Probably, bug: CF not initialized, although comments say so ("probably" >> because I not found in RBIL spec for INT 67/87): J> I also once noted some "RETF 2" instead of "IRET". Doesnt this mean the Trace J> flag is lost, which could cause troubles for not so smart-written debuggers? I don't analyze this aspect. But, probably, you right, and all such places should be changed to modify bits in original flags values on stack. >> 3. Bug: missing popf after @@NO_386: J> I'm afraid noone has a 80286 anymore to test the bugfix. Of course. :) By the same reason other bugs may be not encountered in real life, because conditions for them are unlikely. But this makes bug "less critical", but not makes from bug "not bug". >> Also, in next private email I send diff file with some code >> optimizations. J> Very good! Thanks! Is among the optimizations one for "rep movsd" on P4s? I No, XMS copy routines are not touched, and main goal was code size in speed-non-critical parts. For example, there revised UMBallocate/UMBfree, optimized some "or cx,cx/je" and some other minor optimizations. If you wish, I send diff file for you too. J> remember I once saw a test with various memory move optimizations and the J> winner was almost 3 times as fast as "rep movsd". May be the "XMS block move" J> function can benefit? ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freedos-devel mailing list Freedos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-devel