Hi, I looked into your problem description now...
The "condition is always true" cases are intentionally,
but maybe I should remove the "if (TRUE)" to make that
clear... Actually I had assumed that you only get a
warning when you have "if (some always true expression)"
and not when you use the "obviously true" case "TRUE".
Cases are: bcread.c 99/139: progress indicator display.
createfs.c 664/688: progress indicator display. Those
were "only in debug mode" in old versions of FORMAT.
Your floppy.c does not seem to be current FORMAT 0.91v,
as line numbers differ. You probably mean lines 502/544:
First is "always update params.cyl/sec/sides", not only
if the /f: option is used, and second is an "if (TRUE) {x}"
block which limits the variable scope of variables used in
x to the block x. Maybe you can recommend a better syntax?
The "significant digits lost" warning in prf.c 164 is
int = char* - char* - 1 which can indeed underflow the
returned "count of chars" when you print more than 32k
characters with a single printf... Safe in FORMAT imho.
The code at savefs.c 139 looks okay: I test whether the
number of reserved sectors is below 1 or above 64, why not?
At savefs.c 675, you actually found a buglet: The number of
FATs is unsigned byte, so "if <0 or >2" makes no sense, it
is never below 0. However, it is OR, so it is not always
false. Maybe your savefs.c is an old version?
There is no fdformat.c, probably you mean main.c... If you
get a warning "sysarg0 and syspath never used", then you
probably commented out the code which calls SYS ;-).
The errors about country, mycountry, co_thsep and co_desep
are because your C library implements DOS country support
different than the one used in FORMAT. However, the source
code of FORMAT contains at least 2 versions afair, just
uncomment the one which works for you :-).
Finally, you got some linker errors about duplicate symbols.
This is probably because of a bug in your Makefile ...?
By the way, why are you recompiling FORMAT? If you made
useful changes, I would like to add them to our normal
FORMAT as well. You could send the "diff -ur olddir/ newdir/"
output to describe the differences between your version and
the normal one, but please zip it and send it off-list.
Happy formatting ;-). Eric
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel
