Hi Bart, (and all the other maintainers)

> so in the end the issue is a stack overflow: filenames on the stack
> overflow into a const buffer used by strtok. I had raised it from 2K
> to 4K back in January but that is not enough.
> Since Blair Campbell's LFN work in 2006 cmd_rename() which calls
> fillFnam() together use at least 13 ~256-sized fixed sized filename
> buffers, which is already 3.3K right there.

> You can raise the stack for OW in shell/wlinker.bat to at least 6K,
> maybe 8K is better to be more on the safe side. Or alternatively
> redesign that code a bit to use less stack space.
> Or also just compile without -s to enable stack checking and see what
> that gives. I'll do some more tests tomorrow.

after 5 months since this (16 year old) bug was found, there is still
no official command.com for everybody else to test.

there are also 3 located, and easy fixable bugs in the kernel.

should this not be fixed *before* the next freedos is released, with
known to be buggy software included?

correct licenses may matter for some, but most care more for correct
working software; in particular if the buggy software (kernel and
command)  is the very heart of freedos.

Tom



_______________________________________________
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel

Reply via email to