Hi Bernd, On Wed, 14 Aug 2024 16:37:49 +0200 Bernd Böckmann via Freedos-devel <freedos-devel@lists.sourceforge.net> wrote:
> Hi, > > > Hi Jeremy, hi Bernd, > > is there a decision done what will happen with the "label" problem > > (the labels are written to two different positions) see: > > https://gitlab.com/FreeDOS/issue-reporting/-/issues/31 as this > > problems runs through some more commands if I remember right? > > none that I know of. I think the last one who dealt with the label > stuff was Andrew Bird? Perhaps he knows more... > > A kernel commit was merged on November 10th, 2022: > https://github.com/andrewbird/kernel/commit/106d4cd73b86664776857a4d5e48d106c12bfdcf > > > Bernd > So I have a draft PR open (not ready for merge) on https://github.com/FDOS/kernel/pull/86/commits with that particular commit (which is fine itself), but there are other fixes required in the kernel to fully fix the label problems identified in https://github.com/FDOS/label/issues/17 regarding filename / label collisions. I set out to fix the label problems for both FreeDOS kernel and FDPP was hoping to provide one set of patches that could be applied to each. During my investigation I wrote some label tests for the Dosemu test suite https://github.com/dosemu2/dosemu2/pull/1801/commits and set about fixing the label problems on FDPP first. After much debate a smaller PR https://github.com/dosemu2/fdpp/pull/202 of mine was merged, but this was only possible due to some filesystem fixes that @stsp did for FDPP. With those fixes the label tests now pass on FDPP and I believe the label issue #17 problems would be resolved if the same thing could be done to FreeDOS kernel. The missing bit is that @stsp's changes would need porting to suit FreeDOS. The relevant changes are in the range db77489e0a90adf8b8882b271f1ecc1b94c8de9a to b35072df368579f2a48c45d072ee7fb41c790669 (I'd point you to the commits on Github but it seems to be down), but since I don't understand them fully it would need someone more familiar with fatfs and FreeDOS to do it. If that were done, I'd be happy to rebase and tweak my #86 PR here. Hope that helps, Andrew _______________________________________________ Freedos-devel mailing list Freedos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-devel
