On Thu, 5 Feb 2004, Luchezar Georgiev wrote:

> > EJECT.EXE from PC-DOS 7 (2000) works on MS-DOS 7.10 but not in our
> > current kernel. EJECT H: says "Invalid drive". [...] My conclusion is
> > that while MS-DOS doesn't try to open a H:CON file but opens the
> > CD-ROM device driver instead, which succeeds, FreeDOS tries to access
> > a H:CON file on the CD-ROM and fails.

[...]

> I was slightly wrong. My conclusion was right, but the bug turned out to
> be not in IsDevice() but in DosOpenSft() function in the same dosfns.c
> file. Here's a patch that fixes it. It also fixes the "CHKDSK I:" and
> "SCANDISK I:" "Invalid drive" bugs (not reported yet) where I: is a RAM
> disk. I added it to my patch collection at
> http://linux.tu-varna.acad.bg/~lig/freedos/CVSPATCH.TXT

[...]
> -  if (result & IS_NETWORK)
> +  if ((result & IS_NETWORK) && !(result & IS_DEVICE))
[...]

There's still something fishy here. This fix is wrong in principle:
IS_NETWORK|IS_DEVICE is for cases such as c:\dir\nul where opening it
checks for the existence of c:\dir as well. The network redirector then
has the responibility to open "nul" (perhaps via some int2f/ax=12..
function). So this has to stay, otherwise the check will be broken.

But a straight "H:NUL" is translated to "H:/NUL" in truename (newstuff.c)
and the network bit is reset in line 411... So what you say should not
happen. Well, to conclude, the bug must be somewhere else.

Bart



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel

Reply via email to