On Mon, 12 Apr 2004, Arkady V.Belousov wrote:

> > RCS file: /cvsroot/freedos/kernel/kernel/makefile,v
> > +entry.obj:   entry.asm   segs.inc $(HDR)stacksinc    $(TARGET).lnk
> > +int2f.obj:   int2f.asm   segs.inc $(HDR)stacksinc    $(TARGET).lnk
>
>      Bug: missed dot before "inc".

OK, thanks.

>      Forged to remove old INITHEADERS. Also, what bad in "$(HDR)*.h", why
> enumerating .h files is better?

It's not better as such, but I'm not sure if * works for all the different
make tools we are using. It's safer.

The same problem occurs with !ifdef -- esp Borland MAKE version 2.0.

You might want to check out Turbo C 2.01 as our lowest common denominator
compiler:
http://community.borland.com/article/images/20841/tc201.zip
it's 1074 KB.

> PPS: trailing spaces wasn't removed. :(

Too many formatting changes make me tired when reading the diff...
I don't see the point of changing ":- " to "::".

Similarly you still have too many optimizations which aren't. For Watcom
the code only becomes larger if you replace far pointers p->baz by
explicit ((foo *)MK_FP(bar,0))->baz.

Maybe if you use something like

#if defined(__TURBOC__) && (__TURBOC__ > 0x202)
#define para2far(seg) ((void _seg *)(seg))
#else
#define _seg far
#define para2far(seg) (MK_FP(seg,0))
#endif

psp _seg *p = para2far(cu_psp);
r.es = FP_SEG(p->ps_filetab);
r.di = FP_OFF(p->ps_filetab + bx);

it will improve a bit and it's not too ugly.

Bart



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel

Reply via email to