On 06/18/2016 10:56 PM, weiyj...@163.com wrote:
From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

In case of error, the function drm_mode_duplicate() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Thanks for the fix.

Reviewed-by: Archit Taneja <arch...@codeaurora.org>

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
  drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
index a3e47ad8..97e5a4d 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -2245,9 +2245,9 @@ int msm_dsi_host_set_display_mode(struct mipi_dsi_host 

        msm_host->mode = drm_mode_duplicate(msm_host->dev, mode);
-       if (IS_ERR(msm_host->mode)) {
+       if (!msm_host->mode) {
                pr_err("%s: cannot duplicate mode\n", __func__);
-               return PTR_ERR(msm_host->mode);
+               return -ENOMEM;

        return 0;

To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Freedreno mailing list

Reply via email to