On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote:
> Add an interface to trigger the remote processor to reinitialize the GPU
> zap shader on power-up.
> 
> Signed-off-by: Jordan Crouse <jcro...@codeaurora.org>
> ---

<snip>

> +int __qcom_scm_gpu_zap_resume(struct device *dev)
> +{
> +     struct qcom_scm_desc desc = {0};
> +     struct arm_smccc_res res;
> +     int ret;
> +
> +     desc.args[0] = 0;
> +     desc.args[1] = 13;

Can I get a define here for these two?  Or maybe a comment on what these values
are?

> +     desc.arginfo = QCOM_SCM_ARGS(2);
> +
> +     ret = qcom_scm_call(dev, QCOM_SCM_SVC_BOOT, 0x0A, &desc, &res);

Same with the 0xA.  We usually throw a #define in for the command definitions.

Otherwise this all looks fine.  If you can get back to me with either the values
or a new patch I can include this in the next pull.

Thanks.

Andy
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Reply via email to