On 2018-08-07 05:09, Dan Carpenter wrote:
Hello Jeykumar Sankaran,
This is a semi-automatic email about new static checker warnings.
The patch 25fdd5933e4c: "drm/msm: Add SDM845 DPU support" from Jun
27, 2018, leads to the following Smatch complaint:
./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2464
dpu_encoder_wait_for_event()
warn: variable dereferenced before check 'phys' (see line 2456)
./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
2455 case MSM_ENC_VBLANK:
2456 fn_wait = phys->ops.wait_for_vblank;
^^^^
We always dereference "phys"
2457 break;
2458 default:
2459 DPU_ERROR_ENC(dpu_enc, "unknown wait event
%d\n",
2460 event);
2461 return -EINVAL;
^^^^^^^^^^^^^^
or we return
2462 };
2463
2464 if (phys && fn_wait) {
^^^^
This check is too late.
2465
DPU_ATRACE_BEGIN("wait_for_completion_event");
2466 ret = fn_wait(phys);
regards,
dan carpenter
Thanks for bringing to our attention Dan. Will post a fix for the
warning soon.
--
Jeykumar S
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
