>-----Original Message----- >From: Jonathan Marek <jonat...@marek.ca> >Sent: Tuesday, April 21, 2020 7:41 PM >To: freedreno@lists.freedesktop.org >Cc: Rob Clark <robdcl...@gmail.com>; Sean Paul <s...@poorly.run>; David >Airlie <airl...@linux.ie>; Daniel Vetter <dan...@ffwll.ch>; Jordan Crouse ><jcro...@codeaurora.org>; Sharat Masetty <smase...@codeaurora.org>; >Ruhl, Michael J <michael.j.r...@intel.com>; open list:DRM DRIVER FOR MSM >ADRENO GPU <linux-arm-...@vger.kernel.org>; open list:DRM DRIVER FOR >MSM ADRENO GPU <dri-de...@lists.freedesktop.org>; open list <linux- >ker...@vger.kernel.org> >Subject: [PATCH v2 6/9] drm/msm/a6xx: A640/A650 GMU firmware path > >Newer GPUs have different GMU firmware path. > >Signed-off-by: Jonathan Marek <jonat...@marek.ca> >--- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 135 +++++++++++++++++++- >-- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 11 ++ > drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 6 + > 3 files changed, 136 insertions(+), 16 deletions(-) > >diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >index b22a69e2f4b0..4aef5fe985d6 100644 >--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >@@ -571,6 +571,8 @@ static void a6xx_gmu_power_config(struct a6xx_gmu >*gmu) > { > /* Disable GMU WB/RB buffer */ > gmu_write(gmu, REG_A6XX_GMU_SYS_BUS_CONFIG, 0x1); >+ gmu_write(gmu, REG_A6XX_GMU_ICACHE_CONFIG, 0x1); >+ gmu_write(gmu, REG_A6XX_GMU_DCACHE_CONFIG, 0x1); > > gmu_write(gmu, REG_A6XX_GMU_PWR_COL_INTER_FRAME_CTRL, >0x9c40400); > >@@ -600,14 +602,91 @@ static void a6xx_gmu_power_config(struct >a6xx_gmu *gmu) > A6XX_GMU_RPMH_CTRL_GFX_VOTE_ENABLE); > } > >+static int in_range(u32 addr, u32 start, u32 size) >+{ >+ return addr >= start && addr < start + size; >+}
Minor nit: should this return a bool? M _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno