dev_pm_opp_of_remove_table() doesn't report any errors when it fails to
find the OPP table with error -ENODEV (i.e. OPP table not present for
the device). And we can call dev_pm_opp_of_remove_table()
unconditionally here.

Reviewed-by: Qiang Yu <yuq...@gmail.com>
Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>

---
V2: Applied Reviewed by tag.
---
 drivers/gpu/drm/lima/lima_devfreq.c | 6 +-----
 drivers/gpu/drm/lima/lima_devfreq.h | 1 -
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/lima/lima_devfreq.c 
b/drivers/gpu/drm/lima/lima_devfreq.c
index bbe02817721b..cd290d866a04 100644
--- a/drivers/gpu/drm/lima/lima_devfreq.c
+++ b/drivers/gpu/drm/lima/lima_devfreq.c
@@ -105,10 +105,7 @@ void lima_devfreq_fini(struct lima_device *ldev)
                devfreq->devfreq = NULL;
        }
 
-       if (devfreq->opp_of_table_added) {
-               dev_pm_opp_of_remove_table(ldev->dev);
-               devfreq->opp_of_table_added = false;
-       }
+       dev_pm_opp_of_remove_table(ldev->dev);
 
        if (devfreq->regulators_opp_table) {
                dev_pm_opp_put_regulators(devfreq->regulators_opp_table);
@@ -162,7 +159,6 @@ int lima_devfreq_init(struct lima_device *ldev)
        ret = dev_pm_opp_of_add_table(dev);
        if (ret)
                goto err_fini;
-       ldevfreq->opp_of_table_added = true;
 
        lima_devfreq_reset(ldevfreq);
 
diff --git a/drivers/gpu/drm/lima/lima_devfreq.h 
b/drivers/gpu/drm/lima/lima_devfreq.h
index 5eed2975a375..2d9b3008ce77 100644
--- a/drivers/gpu/drm/lima/lima_devfreq.h
+++ b/drivers/gpu/drm/lima/lima_devfreq.h
@@ -18,7 +18,6 @@ struct lima_devfreq {
        struct opp_table *clkname_opp_table;
        struct opp_table *regulators_opp_table;
        struct thermal_cooling_device *cooling;
-       bool opp_of_table_added;
 
        ktime_t busy_time;
        ktime_t idle_time;
-- 
2.25.0.rc1.19.g042ed3e048af

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Reply via email to