On Fri, 22 Apr 2022 at 11:50, <[email protected]> wrote: > > From: Lv Ruyi <[email protected]> > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon > Chipsets") > Reported-by: Zeal Robot <[email protected]> > Signed-off-by: Lv Ruyi <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index a42732b67349..3926d2ac107d 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1239,7 +1239,7 @@ int dp_display_request_irq(struct msm_dp *dp_display) > dp = container_of(dp_display, struct dp_display_private, dp_display); > > dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0); > - if (dp->irq < 0) { > + if (!dp->irq) { > rc = dp->irq; > DRM_ERROR("failed to get irq: %d\n", rc); > return rc; > -- > 2.25.1 > -- With best wishes Dmitry
