Gentle reminder to review this patch. Thanks, Vinod P.
> -----Original Message----- > From: Vinod Polimera <[email protected]> > Sent: Monday, July 11, 2022 6:27 PM > To: [email protected]; [email protected]; > [email protected]; [email protected] > Cc: Vinod Polimera (QUIC) <[email protected]>; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; Kalyan Thota (QUIC) <[email protected]>; > [email protected]; Kuogee Hsieh (QUIC) > <[email protected]>; Vishnuvardhan Prodduturi (QUIC) > <[email protected]>; [email protected]; Aravind > Venkateswaran (QUIC) <[email protected]>; Abhinav Kumar > (QUIC) <[email protected]>; Sankeerth Billakanti (QUIC) > <[email protected]> > Subject: [PATCH v6 07/10] drm/bridge: add psr support for panel bridge > callbacks > > This change will handle the psr entry exit cases in the panel > bridge atomic callback functions. For example, the panel power > should not turn off if the panel is entering psr. > > Signed-off-by: Sankeerth Billakanti <[email protected]> > Signed-off-by: Vinod Polimera <[email protected]> > --- > drivers/gpu/drm/bridge/panel.c | 48 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/panel.c > b/drivers/gpu/drm/bridge/panel.c > index eeb9546..9770b8c 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -112,6 +112,18 @@ static void panel_bridge_atomic_pre_enable(struct > drm_bridge *bridge, > struct drm_bridge_state *old_bridge_state) > { > struct panel_bridge *panel_bridge = > drm_bridge_to_panel_bridge(bridge); > + struct drm_atomic_state *atomic_state = old_bridge_state- > >base.state; > + struct drm_encoder *encoder = bridge->encoder; > + struct drm_crtc *crtc; > + struct drm_crtc_state *old_crtc_state; > + > + crtc = drm_atomic_get_new_crtc_for_encoder(atomic_state, > encoder); > + if (!crtc) > + return; > + > + old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, > crtc); > + if (old_crtc_state && old_crtc_state->self_refresh_active) > + return; > > drm_panel_prepare(panel_bridge->panel); > } > @@ -120,6 +132,18 @@ static void panel_bridge_atomic_enable(struct > drm_bridge *bridge, > struct drm_bridge_state *old_bridge_state) > { > struct panel_bridge *panel_bridge = > drm_bridge_to_panel_bridge(bridge); > + struct drm_atomic_state *atomic_state = old_bridge_state- > >base.state; > + struct drm_encoder *encoder = bridge->encoder; > + struct drm_crtc *crtc; > + struct drm_crtc_state *old_crtc_state; > + > + crtc = drm_atomic_get_new_crtc_for_encoder(atomic_state, > encoder); > + if (!crtc) > + return; > + > + old_crtc_state = drm_atomic_get_old_crtc_state(atomic_state, > crtc); > + if (old_crtc_state && old_crtc_state->self_refresh_active) > + return; > > drm_panel_enable(panel_bridge->panel); > } > @@ -128,6 +152,18 @@ static void panel_bridge_atomic_disable(struct > drm_bridge *bridge, > struct drm_bridge_state *old_bridge_state) > { > struct panel_bridge *panel_bridge = > drm_bridge_to_panel_bridge(bridge); > + struct drm_atomic_state *atomic_state = old_bridge_state- > >base.state; > + struct drm_encoder *encoder = bridge->encoder; > + struct drm_crtc *crtc; > + struct drm_crtc_state *new_crtc_state; > + > + crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state, > encoder); > + if (!crtc) > + return; > + > + new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, > crtc); > + if (new_crtc_state && new_crtc_state->self_refresh_active) > + return; > > drm_panel_disable(panel_bridge->panel); > } > @@ -136,6 +172,18 @@ static void panel_bridge_atomic_post_disable(struct > drm_bridge *bridge, > struct drm_bridge_state *old_bridge_state) > { > struct panel_bridge *panel_bridge = > drm_bridge_to_panel_bridge(bridge); > + struct drm_atomic_state *atomic_state = old_bridge_state- > >base.state; > + struct drm_encoder *encoder = bridge->encoder; > + struct drm_crtc *crtc; > + struct drm_crtc_state *new_crtc_state; > + > + crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state, > encoder); > + if (!crtc) > + return; > + > + new_crtc_state = drm_atomic_get_new_crtc_state(atomic_state, > crtc); > + if (new_crtc_state && new_crtc_state->self_refresh_active) > + return; > > drm_panel_unprepare(panel_bridge->panel); > } > -- > 2.7.4
