On 08/11/2022 02:56, Bryan O'Donoghue wrote:
Currently we do not differentiate between the various users of the
qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
compatible string but, the hardware does have some significant differences
in the number of clocks.
To facilitate documenting the clocks add the following compatible strings
- qcom,mdss-dsi-ctrl-apq8064
Generic comment: I think we'd better follow the arm/qcom-soc.yaml and
use qcom,soc-something as compat string. This would leave us with
qcom,apq8064-dsi-ctrl
I'm not sure if we want to follow the qcm2290 approach and encode the
DSI ctrl revision here (6g vs v2).
- qcom,mdss-dsi-ctrl-msm8916
- qcom,mdss-dsi-ctrl-msm8974
- qcom,mdss-dsi-ctrl-msm8996
- qcom,mdss-dsi-ctrl-sc7180
- qcom,mdss-dsi-ctrl-sc7280
- qcom,mdss-dsi-ctrl-sdm630
- qcom,mdss-dsi-ctrl-sdm660
- qcom,mdss-dsi-ctrl-sdm845
- qcom,mdss-dsi-ctrl-sm8250
Cc: Rob Clark <[email protected]>
Cc: Abhinav Kumar <[email protected]>
Cc: Dmitry Baryshkov <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Bryan O'Donoghue <[email protected]>
---
.../bindings/display/msm/dsi-controller-main.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index b35130a77b43e..9db3e63acda3d 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -17,6 +17,16 @@ properties:
enum:
- qcom,dsi-ctrl-6g-qcm2290
- qcom,mdss-dsi-ctrl
+ - qcom,mdss-dsi-ctrl-apq8064
+ - qcom,mdss-dsi-ctrl-msm8916
+ - qcom,mdss-dsi-ctrl-msm8974
+ - qcom,mdss-dsi-ctrl-msm8996
+ - qcom,mdss-dsi-ctrl-sc7180
+ - qcom,mdss-dsi-ctrl-sc7280
+ - qcom,mdss-dsi-ctrl-sdm630
+ - qcom,mdss-dsi-ctrl-sdm660
+ - qcom,mdss-dsi-ctrl-sdm845
+ - qcom,mdss-dsi-ctrl-sm8250
reg:
maxItems: 1
--
With best wishes
Dmitry
