On Thu, 1 Dec 2022 at 01:11, Kuogee Hsieh <[email protected]> wrote: > > > On 11/30/2022 10:24 AM, Dmitry Baryshkov wrote: > > On Wed, 30 Nov 2022 at 19:41, Kuogee Hsieh <[email protected]> wrote: > >> > >> On 11/30/2022 1:20 AM, Dmitry Baryshkov wrote: > >>> On Wed, 30 Nov 2022 at 02:12, Kuogee Hsieh <[email protected]> > >>> wrote: > >>>> Move data-lanes property from mdss_dp node to dp_out endpoint. Also > >>>> add link-frequencies property into dp_out endpoint as well. The last > >>>> frequency specified at link-frequencies will be the max link rate > >>>> supported by DP. > >>>> > >>>> Changes in v5: > >>>> -- revert changes at sc7180.dtsi and sc7280.dtsi > >>>> -- add &dp_out to sc7180-trogdor.dtsi and sc7280-herobrine.dtsi > >>> Bindings update? > >> Sorry, I did not get this. > >> > >> Can you please elaborate more specified what exactly you want me to do? > > You need to update device tree bindings. See > > Documentation/devicetree/bindings/display/msm/ > got it, can I submit it as separate patch ?
It is a separate patch, but a part of the series. You have to resubmit it anyway because of changes requested for the patch 2. > > > >>>> Signed-off-by: Kuogee Hsieh <[email protected]> > >>>> --- > >>>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++++- > >>>> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 6 +++++- > >>>> 2 files changed, 10 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > >>>> b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > >>>> index 754d2d6..39f0844 100644 > >>>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > >>>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > >>>> @@ -812,7 +812,11 @@ hp_i2c: &i2c9 { > >>>> status = "okay"; > >>>> pinctrl-names = "default"; > >>>> pinctrl-0 = <&dp_hot_plug_det>; > >>>> - data-lanes = <0 1>; > >>>> +}; > >>>> + > >>>> +&dp_out { > >>>> + data-lanes = <0 1>; > >>>> + link-frequencies = /bits/ 64 <160000000 270000000 540000000>; > >>>> }; > >>>> > >>>> &pm6150_adc { > >>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > >>>> b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > >>>> index 93e39fc..b7c343d 100644 > >>>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > >>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > >>>> @@ -440,7 +440,11 @@ ap_i2c_tpm: &i2c14 { > >>>> status = "okay"; > >>>> pinctrl-names = "default"; > >>>> pinctrl-0 = <&dp_hot_plug_det>; > >>>> - data-lanes = <0 1>; > >>>> +}; > >>>> + > >>>> +&dp_out { > >>>> + data-lanes = <0 1>; > >>>> + link-frequencies = /bits/ 64 <160000000 270000000 540000000 > >>>> 810000000>; > >>>> }; > >>>> > >>>> &mdss_mdp { > >>>> -- > >>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > >>>> Forum, > >>>> a Linux Foundation Collaborative Project > >>>> > > > > -- With best wishes Dmitry
