On 05/12/2022 17:37, Robert Foss wrote:
> The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip.
> 
> In order to toggle the board to enable the HDMI output,
> switch #7 & #8 on the rightmost multi-switch package have
> to be toggled to On.
> 
> Signed-off-by: Robert Foss <robert.f...@linaro.org>

Thank you for your patch. There is something to discuss/improve.

> +
>  &slpi {
>       status = "okay";
>       firmware-name = "qcom/sm8350/slpi.mbn";
> @@ -544,4 +633,20 @@ usb_hub_enabled_state: usb-hub-enabled-state {
>               drive-strength = <2>;
>               output-low;
>       };
> +
> +     lt9611_state: lt9611-state {
> +             lt9611_rst_pin {

No underscores in node names.

> +                     pins = "gpio48";
> +                     function = "normal";
> +
> +                     output-high;
> +                     input-disable;
> +             };
> +
> +             lt9611_irq_pin {

Ditto

> +                     pins = "gpio50";
> +                     function = "gpio";
> +                     bias-disable;
> +             };
> +     };
>  };

Best regards,
Krzysztof

Reply via email to