Hi Jani, I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230124094154.2282778-3-jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info config: arm-defconfig (https://download.01.org/0day-ci/archive/20230124/202301242049.ekzx7rzz-...@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1e92b5478cfc1b0df66153652111117e9548b0d5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 git checkout 1e92b5478cfc1b0df66153652111117e9548b0d5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/tegra/hdmi.c: In function 'tegra_hdmi_write_eld': >> drivers/gpu/drm/tegra/hdmi.c:620:60: error: 'struct drm_connector' has no >> member named 'eld' 620 | size_t length = drm_eld_size(hdmi->output.connector.eld), i; | ^ drivers/gpu/drm/tegra/hdmi.c:624:72: error: 'struct drm_connector' has no member named 'eld' 624 | tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i], | ^ -- drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_write_eld': >> drivers/gpu/drm/tegra/sor.c:1951:59: error: 'struct drm_connector' has no >> member named 'eld' 1951 | size_t length = drm_eld_size(sor->output.connector.eld), i; | ^ drivers/gpu/drm/tegra/sor.c:1954:69: error: 'struct drm_connector' has no member named 'eld' 1954 | tegra_sor_writel(sor, i << 8 | sor->output.connector.eld[i], | ^ vim +620 drivers/gpu/drm/tegra/hdmi.c edec4af4c3d6d2 Thierry Reding 2012-11-15 617 5234549b93aa2a Thierry Reding 2015-08-07 618 static void tegra_hdmi_write_eld(struct tegra_hdmi *hdmi) 5234549b93aa2a Thierry Reding 2015-08-07 619 { 5234549b93aa2a Thierry Reding 2015-08-07 @620 size_t length = drm_eld_size(hdmi->output.connector.eld), i; 5234549b93aa2a Thierry Reding 2015-08-07 621 u32 value; edec4af4c3d6d2 Thierry Reding 2012-11-15 622 5234549b93aa2a Thierry Reding 2015-08-07 623 for (i = 0; i < length; i++) 5234549b93aa2a Thierry Reding 2015-08-07 624 tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i], 5234549b93aa2a Thierry Reding 2015-08-07 625 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR); edec4af4c3d6d2 Thierry Reding 2012-11-15 626 5234549b93aa2a Thierry Reding 2015-08-07 627 /* 5234549b93aa2a Thierry Reding 2015-08-07 628 * The HDA codec will always report an ELD buffer size of 96 bytes and 5234549b93aa2a Thierry Reding 2015-08-07 629 * the HDA codec driver will check that each byte read from the buffer 5234549b93aa2a Thierry Reding 2015-08-07 630 * is valid. Therefore every byte must be written, even if no 96 bytes 5234549b93aa2a Thierry Reding 2015-08-07 631 * were parsed from EDID. 5234549b93aa2a Thierry Reding 2015-08-07 632 */ 5234549b93aa2a Thierry Reding 2015-08-07 633 for (i = length; i < HDMI_ELD_BUFFER_SIZE; i++) 5234549b93aa2a Thierry Reding 2015-08-07 634 tegra_hdmi_writel(hdmi, i << 8 | 0, 5234549b93aa2a Thierry Reding 2015-08-07 635 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR); 5234549b93aa2a Thierry Reding 2015-08-07 636 5234549b93aa2a Thierry Reding 2015-08-07 637 value = SOR_AUDIO_HDA_PRESENSE_VALID | SOR_AUDIO_HDA_PRESENSE_PRESENT; 5234549b93aa2a Thierry Reding 2015-08-07 638 tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_SOR_AUDIO_HDA_PRESENSE); edec4af4c3d6d2 Thierry Reding 2012-11-15 639 } edec4af4c3d6d2 Thierry Reding 2012-11-15 640 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
