Hi Dmitry, thank you for sharing a patch. I tested and can confirm it fixes the issue.
Best regards Leonard On 2/17/24 23:04, Dmitry Baryshkov wrote: > Hi Leonard, > > On Sun, 18 Feb 2024 at 03:17, Leonard Lausen <[email protected]> wrote: >> >> Hi Connor, >> >> unfortunately, your series https://patchwork.freedesktop.org/series/127529/ >> has introduced a regression for external displays connected through USB-C DP >> Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's >> possible to fix this before the 6.8 release or would it be better to revert >> the series? I'm happy to help testing any fixes. The issue is also tracked >> at https://gitlab.freedesktop.org/drm/msm/-/issues/49. > > Please check whether this quick fix works for you > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index c9c55e2ea584..f097577a99ad 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -1325,6 +1325,11 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu > *gpu) > static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > { > struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); > + > + /* a618 is using the hw default values */ > + if (adreno_is_a618(adreno_gpu)) > + return; > + > /* > * We subtract 13 from the highest bank bit (13 is the minimum value > * allowed by hw) and write the lowest two bits of the remaining value > >
