On 27.06.2024 5:54 PM, Marc Gonzalez wrote: > From: Arnaud Vrac <[email protected]> > > Port device nodes from vendor code. > > Signed-off-by: Arnaud Vrac <[email protected]> > Reviewed-by: Dmitry Baryshkov <[email protected]> > Signed-off-by: Marc Gonzalez <[email protected]> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 100 > +++++++++++++++++++++++++++++++++- > 1 file changed, 99 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi > b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index ba5e873f0f35f..417c12534823f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -2785,7 +2785,7 @@ mmcc: clock-controller@c8c0000 { > <&mdss_dsi0_phy 0>, > <&mdss_dsi1_phy 1>, > <&mdss_dsi1_phy 0>, > - <0>, > + <&hdmi_phy 0>, > <0>, > <0>, > <&gcc GCC_MMSS_GPLL0_DIV_CLK>; > @@ -2890,6 +2890,14 @@ dpu_intf2_out: endpoint { > remote-endpoint = > <&mdss_dsi1_in>; > }; > }; > + > + port@2 { > + reg = <2>; > + > + dpu_intf3_out: endpoint { > + remote-endpoint = > <&hdmi_in>; > + }; > + }; > }; > }; > > @@ -3045,6 +3053,96 @@ mdss_dsi1_phy: phy@c996400 { > > status = "disabled"; > }; > + > + hdmi: hdmi-tx@c9a0000 {
Please prefix the labels (hdmi: and hdmi_phy:) with mdss_ Otherwise, this looks good Reviewed-by: Konrad Dybcio <[email protected]> One thing I noticed (testing on the 8998 MTP), enabling MDSS (not necessarily HDMI, mdss and mdp is enough) results in SMMU lockups about 30% of the time.. [ 4.911422] arm-smmu cd00000.iommu: FSR = 00000402 [Format=2 TF], SID=0x0 [ 4.913412] platform c901000.display-controller: Fixed dependency cycle(s) with /soc@0/display-subsystem@c900000/hdmi-tx@c9a0000 [ 4.923353] arm-smmu cd00000.iommu: FSYNR0 = 00000021 [S1CBNDX=0 PNU PLVL=1] [ 4.927893] arm-smmu cd00000.iommu: FSR = 00000402 [Format=2 TF], SID=0x0 [ 4.930647] platform c9a0000.hdmi-tx: Fixed dependency cycle(s) with /soc@0/display-subsystem@c900000/display-controller@c901000 [ 4.941928] arm-smmu cd00000.iommu: FSYNR0 = 00000021 [S1CBNDX=0 PNU PLVL=1] [ 4.944438] arm-smmu cd00000.iommu: FSR = 00000402 [Format=2 TF], SID=0x0 [ 4.952338] msm_hdmi_phy c9a0600.hdmi-phy: supply vddio not found, using dummy regulator [ 4.956013] arm-smmu cd00000.iommu: FSYNR0 = 00000021 [S1CBNDX=0 PNU PLVL=1] [ 4.961055] arm-smmu cd00000.iommu: FSR = 00000402 [Format=2 TF], SID=0x0 [ 4.967917] msm_hdmi_phy c9a0600.hdmi-phy: supply vcca not found, using dummy regulator [ 4.974565] arm-smmu cd00000.iommu: FSYNR0 = 00000021 [S1CBNDX=0 PNU PLVL=1] [ 4.977628] arm-smmu cd00000.iommu: FSR = 00000402 [Format=2 TF], SID=0x0 [ 4.984122] Bluetooth: hci0: setting up wcn399x [ 4.989670] arm-smmu cd00000.iommu: FSYNR0 = 00000021 [S1CBNDX=0 PNU PLVL=1] Konrad
