On 9/12/2025 9:24 AM, Dmitry Baryshkov wrote: > On Thu, Sep 11, 2025 at 10:55:01PM +0800, Xiangxu Yin wrote: >> Introduce QCS615 hardware-specific configuration for DP PHY mode, >> including register offsets, initialization tables, voltage swing >> and pre-emphasis settings. >> >> Add qcs615-qmp-usb3-dp-phy compatible string to associate QCS615 >> platform with its USB/DP switchable PHY configuration. > This should be the last patch in the series: once you add the compatible > string, it is expected that it works. > > The patch LGTM.
In v3[12/14], the compatible string was placed in the last, and you remind me will trigger unused warnings for the earlier-defined qcs615_usb3dp_phy_cfg. So I merged them in v4. If move this patch to the end, patch v4[07/13] will hit unused warnings due to missing references. Should I squash patches 04 & 07 and move them to the end? I'm concerned the resulting patch might be too large. >> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com> >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 141 >> +++++++++++++++++++++++++++++++ >> 1 file changed, 141 insertions(+) >>
