On Fri, Sep 12, 2025 at 07:53:50PM +0800, Xiangxu Yin wrote: > > On 9/12/2025 7:47 PM, Dmitry Baryshkov wrote: > > On Fri, Sep 12, 2025 at 07:39:17PM +0800, Xiangxu Yin wrote: > >> Add support for SM6150 DisplayPort controller, which shares base offset > >> and configuration with SC7180. While SM6150 lacks some SC7180 features > >> (e.g. HBR3, MST), current msm_dp_desc_sc7180 data is sufficient. Listing it > > SM6150 supports MST as far as I can see. > > > Yes, but since msm_dp_desc hasn't been mainlined with MST enabled yet, > I went ahead and submitted it with this commit message.
The commit message is misleading: it makes one think that SC7180 supports MST, while SM6150 doesn't. > > > >> explicitly ensures future compatibility. > >> > >> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com> > >> --- > >> drivers/gpu/drm/msm/dp/dp_display.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index > >> d87d47cc7ec3eb757ac192c411000bc50b824c59..ddb22b50490035779904d4cab20e2fee7e0f9657 > >> 100644 > >> --- a/drivers/gpu/drm/msm/dp/dp_display.c > >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c > >> @@ -196,6 +196,7 @@ static const struct of_device_id msm_dp_dt_match[] = { > >> { .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp }, > >> { .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp }, > >> { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 }, > >> + { .compatible = "qcom,sm6150-dp", .data = &msm_dp_desc_sc7180 }, > >> { .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 }, > >> { .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 }, > >> { .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 }, > >> > >> -- > >> 2.34.1 > >> -- With best wishes Dmitry