On 10/10/25 7:49 PM, Anna Maniscalco wrote: > When keepalive vote is set to false IFPC will be re-enabled even if the > perfcounter oob vote is set. > > Workaround this by not setting keepalive vote when sysprof is active. > > --- > I have little confidence that this is the proper solution hence why > this is an RFC. > > Hopefully something better can be found. > > Signed-off-by: Anna Maniscalco <[email protected]> > --- > drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c > b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c > index > afc5f4aa3b17334027f3c20072cc3f059a9733b7..975b91e2c439f659b7f716cff87f73d389641d91 > 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c > @@ -191,7 +191,8 @@ void a6xx_preempt_irq(struct msm_gpu *gpu) > > set_preempt_state(a6xx_gpu, PREEMPT_NONE); > > - a6xx_preempt_keepalive_vote(gpu, false); > + if (refcount_read(&a6xx_gpu->base.base.sysprof_active) <= 0)
This returns an unsigned type, so you can just do: if (!refcount_read(..)) Konrad > + a6xx_preempt_keepalive_vote(gpu, false); > > trace_msm_gpu_preemption_irq(a6xx_gpu->cur_ring->id); > > > --- > base-commit: b5bad77e1e3c7249e4c0c88f98477e1ee7669b63 > change-id: 20251010-ifpc_counters_fix-8bd4470e6351 > > Best regards,
