On Tue, Feb 17, 2026 at 12:44:19PM +0530, Mani Chandana Ballary Kuntumalla 
wrote:
> From: Mani Chandana Ballary Kuntumalla <[email protected]>
> 
> Add devicetree changes to enable second Mobile Display Subsystem (mdss1),
> Display Processing Unit(DPU), Display Port(DP) controllers and eDP PHYs
> on the Qualcomm Lemans platform.
> 
> Signed-off-by: Mahadevan P <[email protected]>
> Signed-off-by: Mani Chandana Ballary Kuntumalla <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/lemans.dtsi | 315 ++++++++++++++++++++++++++-
>  1 file changed, 313 insertions(+), 2 deletions(-)
> 

> +
> +                             mdss1_mdp_opp_table: opp-table {

The OPP table is the same as the one used by MDSS0. Please move the OPP
table one layer up and use it for both nodes.

> +                                     compatible = "operating-points-v2";
> +
> +                                     opp-375000000 {
> +                                             opp-hz = /bits/ 64 <375000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_svs_l1>;
> +                                     };
> +
> +                                     opp-500000000 {
> +                                             opp-hz = /bits/ 64 <500000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_nom>;
> +                                     };
> +
> +                                     opp-575000000 {
> +                                             opp-hz = /bits/ 64 <575000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_turbo>;
> +                                     };
> +
> +                                     opp-650000000 {
> +                                             opp-hz = /bits/ 64 <650000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_turbo_l1>;
> +                                     };
> +                             };
> +                     };
> +

> +                             mdss1_dp_opp_table: opp-table {

The same comment, use common OPP table.

> +                                     compatible = "operating-points-v2";
> +
> +                                     opp-160000000 {
> +                                             opp-hz = /bits/ 64 <160000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_low_svs>;
> +                                     };
> +
> +                                     opp-270000000 {
> +                                             opp-hz = /bits/ 64 <270000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_svs>;
> +                                     };
> +
> +                                     opp-540000000 {
> +                                             opp-hz = /bits/ 64 <540000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_svs_l1>;
> +                                     };
> +
> +                                     opp-810000000 {
> +                                             opp-hz = /bits/ 64 <810000000>;
> +                                             required-opps = 
> <&rpmhpd_opp_nom>;
> +                                     };
> +                             };
> +                     };
> +

> @@ -7055,13 +7366,13 @@ dispcc1: clock-controller@22100000 {
>                                <&rpmhcc RPMH_CXO_CLK>,
>                                <&rpmhcc RPMH_CXO_CLK_A>,
>                                <&sleep_clk>,
> -                              <0>, <0>, <0>, <0>,
> +                              <&mdss1_dp0_phy 0>, <&mdss1_dp0_phy 1>,
> +                              <&mdss1_dp1_phy 0>, <&mdss1_dp1_phy 1>,
>                                <0>, <0>, <0>, <0>;
>                       power-domains = <&rpmhpd SA8775P_MMCX>;
>                       #clock-cells = <1>;
>                       #reset-cells = <1>;
>                       #power-domain-cells = <1>;
> -                     status = "disabled";

This needs to be explained in the commit messages.

>               };
>  
>               ethernet1: ethernet@23000000 {
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Reply via email to