Re: [PATCH v5 3/6] drm/colorop: Remove read-only comments from interpolation fields

[Borah, Chaitanya Kumar]

On 5/7/2026 12:53 AM, Melissa Wen wrote:

From: Alex Hung <alex.h...@amd.com>

The lut1d_interpolation and lut3d_interpolation fields and their
associated properties were marked as read-only, but userspace
can set them via drm_atomic_colorop_set_property().

Signed-off-by: Alex Hung <alex.h...@amd.com>

LGTM.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.bo...@intel.com>

---
  include/drm/drm_colorop.h | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h
index bd082854ca74..61cc8206b4c4 100644
--- a/include/drm/drm_colorop.h
+++ b/include/drm/drm_colorop.h
@@ -309,7 +309,6 @@ struct drm_colorop {
        /**
         * @lut1d_interpolation:
         *
-        * Read-only
         * Interpolation for DRM_COLOROP_1D_LUT
         */
        enum drm_colorop_lut1d_interpolation_type lut1d_interpolation;
@@ -317,7 +316,6 @@ struct drm_colorop {
        /**
         * @lut3d_interpolation:
         *
-        * Read-only
         * Interpolation for DRM_COLOROP_3D_LUT
         */
        enum drm_colorop_lut3d_interpolation_type lut3d_interpolation;
@@ -325,7 +323,7 @@ struct drm_colorop {
        /**
         * @lut1d_interpolation_property:
         *
-        * Read-only property for DRM_COLOROP_1D_LUT interpolation
+        * Property for DRM_COLOROP_1D_LUT interpolation
         */
        struct drm_property *lut1d_interpolation_property;

@@ -353,7 +351,7 @@ struct drm_colorop {

        /**
         * @lut3d_interpolation_property:
         *
-        * Read-only property for DRM_COLOROP_3D_LUT interpolation
+        * Property for DRM_COLOROP_3D_LUT interpolation
         */
        struct drm_property *lut3d_interpolation_property;