On 8/24/26 1:28 PM, Saurabh Anand wrote: > msm_dp_display_prepare_link() sets force_link_train = true before calling > msm_dp_ctrl_on_link(). On success the flag was never cleared, so > msm_dp_ctrl_prepare_stream_on() would unconditionally trigger a second > link retrain even though the link was already trained. > > Clear force_link_train on the success path so that > msm_dp_ctrl_prepare_stream_on() only retrains when the channel EQ check > fails, as intended. > > Signed-off-by: Saurabh Anand <[email protected]> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bc646d172abe..40e19d506a45 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -649,6 +649,8 @@ static int msm_dp_display_prepare_link(struct > msm_dp_display_private *dp) > return rc; > } > > + force_link_train = false; > + > return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, > force_link_train);
This makes the argument of this function useless Konrad
