URL: https://github.com/freeipa/freeipa/pull/945
Author: MartinBasti
Title: #945: DNS update: reduce timeout for CA records
Action: opened
PR body:
"""
Timeout 120 seconds is quite long and it makes uninstallation too long
for. Given that this is non critical operation and may be executed
manually later, waiting 120 seconds is too much. Usually waiting longer
will not help at all to resolve missing record.
30 seconds is long enough 🕯
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/945/head:pr945
git checkout pr945
From abbad9d68880c635482e8c6df7ff17348a412d79 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 28 Jul 2017 15:43:16 +0200
Subject: [PATCH] DNS update: reduce timeout for CA records
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Timeout 120 seconds is quite long and it makes uninstallation too long
for. Given that this is non critical operation and may be executed
manually later, waiting 120 seconds is too much. Usually waiting longer
will not help at all to resolve missing record.
30 seconds is long enough 🕯
---
ipaserver/dns_data_management.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ipaserver/dns_data_management.py b/ipaserver/dns_data_management.py
index 9965028ce0..bdf83de0cd 100644
--- a/ipaserver/dns_data_management.py
+++ b/ipaserver/dns_data_management.py
@@ -55,6 +55,8 @@
(DNSName("_ntp._udp"), 123),
)
+CA_RECORDS_DNS_TIMEOUT = 30 # timeout in seconds
+
class IPADomainIsNotManagedByIPAError(Exception):
pass
@@ -134,7 +136,7 @@ def __add_ca_records_from_hostname(self, zone_obj, hostname):
assert isinstance(hostname, DNSName) and hostname.is_absolute()
r_name = DNSName('ipa-ca') + self.domain_abs
rrsets = []
- end_time = time() + 120 # timeout in seconds
+ end_time = time() + CA_RECORDS_DNS_TIMEOUT
while time() < end_time:
try:
rrsets = resolve_rrsets(hostname, (rdatatype.A, rdatatype.AAAA))
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
