URL: https://github.com/freeipa/freeipa/pull/953
Author: pvomacka
 Title: #953: [master] WebUI: Turn on pagination on certificate page
Action: opened

PR body:
"""
Almost all other search tables use pagination. Only this one does not.
This change makes WebUI more consistent.

https://pagure.io/freeipa/issue/6079
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/953/head:pr953
git checkout pr953
From 39bc12c3aee2e48d310aa10ba85c2fc0e35d3aa3 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka <pvoma...@redhat.com>
Date: Tue, 25 Jul 2017 16:49:36 +0200
Subject: [PATCH] WebUI: Turn on pagination on certificate page

Almost all other search tables use pagination. Only this one does not.
This change makes WebUI more consistent.

https://pagure.io/freeipa/issue/6079
---
 install/ui/src/freeipa/certificate.js | 6 +++++-
 install/ui/src/freeipa/facet.js       | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/install/ui/src/freeipa/certificate.js b/install/ui/src/freeipa/certificate.js
index 0cb43c718f..2168505ed4 100755
--- a/install/ui/src/freeipa/certificate.js
+++ b/install/ui/src/freeipa/certificate.js
@@ -1647,7 +1647,11 @@ return {
             facet_groups: [exp.facet_group],
             facet_group: 'certificates',
             additional_navigation_arguments: [ 'cacn' ],
-            pagination: false,
+            command_options: { all: true },
+            dont_call_show_method: true,
+            search_all_entries: true,
+            sort_enabled: false,
+            show_values_with_dup_key: true,
             no_update: true,
             columns: [
                 {
diff --git a/install/ui/src/freeipa/facet.js b/install/ui/src/freeipa/facet.js
index 2bf5b96289..16bc0bd365 100644
--- a/install/ui/src/freeipa/facet.js
+++ b/install/ui/src/freeipa/facet.js
@@ -2180,7 +2180,7 @@ exp.table_facet = IPA.table_facet = function(spec, no_init) {
             return;
         }
 
-        if (that.search_all_entries) {
+        if (that.search_all_entries && !that.pagination) {
             // map contains the primary keys and the complete records
             that.load_records(records_map.values);
             return;
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to