URL: https://github.com/freeipa/freeipa/pull/1071
Author: stlaz
 Title: #1071: client: fix retrieving certs from HTTP
Action: opened

PR body:
"""
We're applying bytes regex on the result of a command but were
using decoded stdout instead of raw.

https://pagure.io/freeipa/issue/7131
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1071/head:pr1071
git checkout pr1071
From fa96f21a95f3ef2d7b9d1787b75668c91182f4e0 Mon Sep 17 00:00:00 2001
From: Stanislav Laznicka <slazn...@redhat.com>
Date: Wed, 13 Sep 2017 08:22:00 +0200
Subject: [PATCH] client: fix retrieving certs from HTTP

We're applying bytes regex on the result of a command but were
using decoded stdout instead of raw.

https://pagure.io/freeipa/issue/7131
---
 ipaclient/install/client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaclient/install/client.py b/ipaclient/install/client.py
index b7293bb29f..3eb619c1ff 100644
--- a/ipaclient/install/client.py
+++ b/ipaclient/install/client.py
@@ -1615,7 +1615,7 @@ def get_ca_certs_from_http(url, warn=True):
         result = run([paths.BIN_CURL, "-o", "-", url], capture_output=True)
     except CalledProcessError:
         raise errors.NoCertificateError(entry=url)
-    stdout = result.output
+    stdout = result.raw_output
 
     try:
         certs = x509.load_certificate_list(stdout)
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to