URL: https://github.com/freeipa/freeipa/pull/1072
Author: stlaz
 Title: #1072: [Backport][ipa-4-6] client: fix retrieving certs from HTTP
Action: opened

PR body:
This PR was opened automatically because PR #1071 was pushed to master and 
backport to ipa-4-6 is required.

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1072/head:pr1072
git checkout pr1072
From 57b10ec45071fbea6b82674ff030abdc668b668d Mon Sep 17 00:00:00 2001
From: Stanislav Laznicka <slazn...@redhat.com>
Date: Wed, 13 Sep 2017 08:22:00 +0200
Subject: [PATCH] client: fix retrieving certs from HTTP

We're applying bytes regex on the result of a command but were
using decoded stdout instead of raw.

 ipaclient/install/client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaclient/install/client.py b/ipaclient/install/client.py
index e971aeab48..8d705198a9 100644
--- a/ipaclient/install/client.py
+++ b/ipaclient/install/client.py
@@ -1615,7 +1615,7 @@ def get_ca_certs_from_http(url, warn=True):
         result = run([paths.BIN_CURL, "-o", "-", url], capture_output=True)
     except CalledProcessError:
         raise errors.NoCertificateError(entry=url)
-    stdout = result.output
+    stdout = result.raw_output
         certs = x509.load_certificate_list(stdout)
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to