URL: https://github.com/freeipa/freeipa/pull/1534 Author: tiran Title: #1534: [Backport][ipa-4-6] Make IntegrationTest fail if an error happened during uninstall Action: opened
PR body: """ This PR was opened automatically because PR #1459 was pushed to master and backport to ipa-4-6 is required. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1534/head:pr1534 git checkout pr1534
From be54239bfc51913216c2f362c911308731900667 Mon Sep 17 00:00:00 2001 From: Felipe Barreto <fbarr...@redhat.com> Date: Fri, 26 Jan 2018 14:31:14 -0200 Subject: [PATCH] Make IntegrationTest fail if an error happened during uninstall Before this change, if the uninstall process fails, the test would not fail, due to the raiseonerr=False. It's necessary to remove the uninstall call in CALessBase because in TestIntegration there is another uninstall call. So, without the raiseonerr=False, it would make the uninstall process fail, since the master is already uninstalled. https://pagure.io/freeipa/issue/7357 --- ipatests/pytest_plugins/integration/tasks.py | 2 +- ipatests/test_integration/test_caless.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/ipatests/pytest_plugins/integration/tasks.py b/ipatests/pytest_plugins/integration/tasks.py index a6fdca39e6..d9ba187d92 100644 --- a/ipatests/pytest_plugins/integration/tasks.py +++ b/ipatests/pytest_plugins/integration/tasks.py @@ -710,7 +710,7 @@ def uninstall_master(host, ignore_topology_disconnect=True, if ignore_last_of_role and host_domain_level != DOMAIN_LEVEL_0: uninstall_cmd.append('--ignore-last-of-role') - host.run_command(uninstall_cmd, raiseonerr=False) + host.run_command(uninstall_cmd) host.run_command(['pkidestroy', '-s', 'CA', '-i', 'pki-tomcat'], raiseonerr=False) host.run_command(['rm', '-rf', diff --git a/ipatests/test_integration/test_caless.py b/ipatests/test_integration/test_caless.py index 76f40292fd..09973dd1f8 100644 --- a/ipatests/test_integration/test_caless.py +++ b/ipatests/test_integration/test_caless.py @@ -159,8 +159,6 @@ def install(cls, mh): def uninstall(cls, mh): # Remove the NSS database shutil.rmtree(cls.cert_dir) - for host in cls.get_all_hosts(): - tasks.uninstall_master(host) super(CALessBase, cls).uninstall(mh) @classmethod
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
