URL: https://github.com/freeipa/freeipa/pull/1600 Author: Tiboris Title: #1600: [Backport][ipa-4-6] fastcheck: do not test context in pycodestyle Action: opened
PR body: """ `git diff` shows also context lines by default. When passed to pycodestyle it can produce errors unrelated to changed lines. It prevents running of subsequent checks. Limiting context to 0 lines by `git diff -U0` enables to test only the modified lines and allows to run subsequent checks. Reviewed-By: Christian Heimes <chei...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1600/head:pr1600 git checkout pr1600
From 361511e18ca6a3d661655108c6133d7c8b6c74be Mon Sep 17 00:00:00 2001 From: Petr Vobornik <pvobo...@redhat.com> Date: Fri, 16 Feb 2018 17:23:23 +0100 Subject: [PATCH] fastcheck: do not test context in pycodestyle `git diff` shows also context lines by default. When passed to pycodestyle it can produce errors unrelated to changed lines. It prevents running of subsequent checks. Limiting context to 0 lines by `git diff -U0` enables to test only the modified lines and allows to run subsequent checks. Reviewed-By: Christian Heimes <chei...@redhat.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index a4381dd071..21fb6d19c7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -215,7 +215,7 @@ endif echo -e "Fast linting files:\n$${FILES}\n"; \ echo "pycodestyle"; \ echo "-----------"; \ - git diff $${MERGEBASE} | \ + git diff -U0 $${MERGEBASE} | \ $(PYTHON) -m pycodestyle --diff || exit $$?; \ echo -e "\npylint"; \ echo "------"; \
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org