URL: https://github.com/freeipa/freeipa/pull/1615
Author: tiran
 Title: #1615: Remove deprecated -p option from ipa-dns-install
Action: opened

PR body:
"""
The option has been deprecated since at least freeIPA release 4.3.0 when
the installer was changed to use LDAPI.

See: https://pagure.io/freeipa/issue/4933
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1615/head:pr1615
git checkout pr1615
From a555a0f79b5489f85254380db3ffded8432b4c49 Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Thu, 22 Feb 2018 14:28:47 +0100
Subject: [PATCH] Remove deprecated -p option from ipa-dns-install

The option has been deprecated since at least freeIPA release 4.3.0 when
the installer was changed to use LDAPI.

See: https://pagure.io/freeipa/issue/4933
Signed-off-by: Christian Heimes <chei...@redhat.com>
---
 install/tools/ipa-dns-install | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/install/tools/ipa-dns-install b/install/tools/ipa-dns-install
index 63f3d2afa8..d3f227aebf 100755
--- a/install/tools/ipa-dns-install
+++ b/install/tools/ipa-dns-install
@@ -25,8 +25,6 @@ import logging
 import os
 import sys
 
-from optparse import SUPPRESS_HELP  # pylint: disable=deprecated-module
-
 from ipaserver.install import bindinstance
 from ipaserver.install import installutils
 from ipapython import version
@@ -44,8 +42,6 @@ log_file_name = paths.IPASERVER_INSTALL_LOG
 
 def parse_options():
     parser = IPAOptionParser(version=version.VERSION)
-    parser.add_option("-p", "--ds-password", dest="dm_password",
-                      sensitive=True, help=SUPPRESS_HELP)
     parser.add_option("-d", "--debug", dest="debug", action="store_true",
                       default=False, help="print debugging information")
     parser.add_option("--ip-address", dest="ip_addresses", metavar="IP_ADDRESS",
@@ -116,9 +112,6 @@ def parse_options():
     if options.kasp_db_file and not os.path.isfile(options.kasp_db_file):
         parser.error("File %s does not exist" % options.kasp_db_file)
 
-    if options.dm_password:
-        print ("WARNING: Option -p/--ds-password is deprecated "
-               "and should not be used anymore.")
     return safe_options, options
 
 def main():
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to