URL: https://github.com/freeipa/freeipa/pull/1658 Author: amitkumar50 Title: #1658: Misleading error message XXX-del for non-existent objects Action: opened
PR body: """ ipa ca-del does not provide relevant log message when ipa-server user tries deleting non-exitant CA. `# ipa ca-del SubCA_9 SubCA_10 --continue` `-------------` Deleted CA "" `-------------` Failed to remove: SubCA_9, SubCA_10 --continue option itself says Don't stop on errors. So it will try deleting CAs anyhow. I believe better would be to change text from Deleted CA to something: Trying to Delete CA Resolves: https://pagure.io/freeipa/issue/6106 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1658/head:pr1658 git checkout pr1658
From 892970986e023b648106693254c47d48099f8cd2 Mon Sep 17 00:00:00 2001 From: amitkuma <amitk...@redhat.com> Date: Wed, 7 Mar 2018 20:12:08 +0530 Subject: [PATCH] Misleading error message XXX-del for non-existent objects ipa ca-del does not provide relevant log message when ipa-server user tries deleting non-exitant CA. # ipa ca-del SubCA_9 SubCA_10 --continue ------------- Deleted CA "" ------------- Failed to remove: SubCA_9, SubCA_10 # --continue option itself says Don't stop on errors. So it will try deleting CAs anyhow. I believe better would be to change text from Deleted CA to something: Trying to Delete CA Resolves: https://pagure.io/freeipa/issue/6106 --- ipaserver/plugins/ca.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaserver/plugins/ca.py b/ipaserver/plugins/ca.py index 88e7ec2a9f..af7b3d6da6 100644 --- a/ipaserver/plugins/ca.py +++ b/ipaserver/plugins/ca.py @@ -292,7 +292,7 @@ def post_callback(self, ldap, dn, entry_attrs, *keys, **options): class ca_del(LDAPDelete): __doc__ = _('Delete a CA.') - msg_summary = _('Deleted CA "%(value)s"') + msg_summary = _('Trying to Delete CA "%(value)s"') def pre_callback(self, ldap, dn, *keys, **options): ca_enabled_check(self.api)
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
