URL: https://github.com/freeipa/freeipa/pull/1659
Author: Tiboris
Title: #1659: Do not check deleted files with `make fastlint`
Action: opened
PR body:
"""
When any file from FreeIPA tree has been deleted there was
a failure like:
```
pylint
------
************* Module ipaserver/install/ntpinstance.py
ipaserver/install/ntpinstance.py:1: [F0001(fatal), ] No module named
ipaserver/install/ntpinstance.py)
```
Adding --diff-filter to fastlint will not list deleted files
in git diff --names-only output to not include not existing
files to checklist.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1659/head:pr1659
git checkout pr1659
From 67eb1c7977ace4d95b3b1bee3c81df8974615d8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tibor=20Dudl=C3=A1k?= <tdud...@redhat.com>
Date: Wed, 7 Mar 2018 15:14:36 +0100
Subject: [PATCH] Do not check deleted files with `make fastlint`
when any file from FreeIPA tree has been deleted there was
a failure like:
pylint
------
************* Module ipaserver/install/ntpinstance.py
ipaserver/install/ntpinstance.py:1: [F0001(fatal), ] No module named ipaserver/install/ntpinstance.py)
Adding --diff-filter to fastlint will not list deleted files
in git diff --names-only output to not include not existing
files to checklist.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 21fb6d19c7..231ae17e08 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -209,7 +209,7 @@ endif
@echo "Fast linting with $(PYTHON) from branch '$(GIT_BRANCH)'"
@MERGEBASE=$$(git merge-base --fork-point $(GIT_BRANCH)); \
- FILES=$$(git diff --name-only $${MERGEBASE} \
+ FILES=$$(git diff --name-only --diff-filter=AMRC $${MERGEBASE} \
| grep -E '\.py$$'); \
if [ -n "$${FILES}" ]; then \
echo -e "Fast linting files:\n$${FILES}\n"; \
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
