URL: https://github.com/freeipa/freeipa/pull/1922
Author: slaykovsky
Title: #1922: Radius proxy multiservers fix
Action: opened
PR body:
"""
Now radius proxy plugin allows to add more then one radius server
into radius proxy but the first one from ldap response is being
parsed (you can see ./daemons/ipa-optd/parse.c).
So this kind of behaviour is a bug, as it was determined on IRC.
This patch removes possibility to add more then one radius server
into radius proxy.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1922/head:pr1922
git checkout pr1922
From 6612659bd6ee845dd3e821b3eaa5634b417d03a9 Mon Sep 17 00:00:00 2001
From: Aleksei Slaikovskii <aslai...@redhat.com>
Date: Mon, 14 May 2018 08:55:56 +0200
Subject: [PATCH] Radius proxy multiservers fix
Now radius proxy plugin allows to add more then one radius server
into radius proxy but the first one from ldap response is being
parsed (you can see ./daemons/ipa-optd/parse.c).
So this kind of behaviour is a bug, as it was determined on IRC.
This patch removes possibility to add more then one radius server
into radius proxy.
---
install/ui/src/freeipa/radiusproxy.js | 12 +++---------
ipaserver/plugins/radiusproxy.py | 2 +-
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/install/ui/src/freeipa/radiusproxy.js b/install/ui/src/freeipa/radiusproxy.js
index 056d9504c1..d4283f72cd 100644
--- a/install/ui/src/freeipa/radiusproxy.js
+++ b/install/ui/src/freeipa/radiusproxy.js
@@ -66,10 +66,7 @@ return {
$type: 'textarea',
name: 'description'
},
- {
- $type: 'multivalued',
- name: 'ipatokenradiusserver' // TODO: add validation
- },
+ 'ipatokenradiusserver', // TODO: add validation
'ipatokenusermapattribute', // TODO: add validation
'ipatokenradiustimeout',
'ipatokenradiusretries'
@@ -90,10 +87,7 @@ return {
adder_dialog: {
fields: [
'cn',
- {
- $type: 'multivalued',
- name: 'ipatokenradiusserver'
- },
+ 'ipatokenradiusserver',
{
$type: 'password',
name: 'ipatokenradiussecret'
@@ -130,4 +124,4 @@ radiusproxy.register = function() {
phases.on('registration', radiusproxy.register);
return radiusproxy;
-});
\ No newline at end of file
+});
diff --git a/ipaserver/plugins/radiusproxy.py b/ipaserver/plugins/radiusproxy.py
index be77c62432..f638431f69 100644
--- a/ipaserver/plugins/radiusproxy.py
+++ b/ipaserver/plugins/radiusproxy.py
@@ -116,7 +116,7 @@ class radiusproxy(LDAPObject):
label=_('Description'),
doc=_('A description of this RADIUS proxy server'),
),
- Str('ipatokenradiusserver+', validate_radiusserver,
+ Str('ipatokenradiusserver', validate_radiusserver,
cli_name='server',
label=_('Server'),
doc=_('The hostname or IP (with or without port)'),
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
