URL: https://github.com/freeipa/freeipa/pull/1935
Author: amitkumar50
 Title: #1935: ipa vault-archive overwrites an existing value without warning
Action: opened

PR body:
"""
Upstream ticket was raised for issuing an warning message
whenever data in ipa vault is overwritten.

In Bugzilla(1339129) its agreed upon that Current behavior is consistent
with other IPA commands. None of ipa mod commands asks for confirmation
and therefore it should be the same here.
But to document, that vault can contain only one value in ipa help vault.

This PR addresses the changes agreed in Bugzilla.

Resolves: https://pagure.io/freeipa/issue/5922
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1935/head:pr1935
git checkout pr1935
From 66fece6e702ab9ccb32a48b825453573040d3da4 Mon Sep 17 00:00:00 2001
From: amitkumar50 <amitk...@redhat.com>
Date: Thu, 17 May 2018 15:47:19 +0530
Subject: [PATCH] ipa vault-archive overwrites an existing value without
 warning

Upstream ticket was raised for issuing an warning message
whenever data in ipa vault is overwritten.

In Bugzilla(1339129) its agreed upon that Current behavior is consistent
with other IPA commands. None of ipa mod commands asks for confirmation
and therefore it should be the same here.
But to document, that vault can contain only one value in ipa help vault.

This PR addresses the changes agreed in Bugzilla.

Resolves: https://pagure.io/freeipa/issue/5922
---
 ipaserver/plugins/vault.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ipaserver/plugins/vault.py b/ipaserver/plugins/vault.py
index 135a51846d..f7ae3007c1 100644
--- a/ipaserver/plugins/vault.py
+++ b/ipaserver/plugins/vault.py
@@ -55,7 +55,10 @@
 """) + _("""
 Manage vaults.
 """) + _("""
-Vault is a secure place to store a secret.
+Vault is a secure place to store a secret. One vault can only
+store one secret. Contents of vault would be overwritten if
+at all present.
+
 """) + _("""
 Based on the ownership there are three vault categories:
 * user/private vault
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/JFS7DE5EMDAHU5UAPYCCX4NZUBOAP3C4/

Reply via email to