URL: https://github.com/freeipa/freeipa/pull/1955
Author: flo-renaud
 Title: #1955: [Backport][ipa-4-6] ipa vault-archive overwrites an existing 
value without warning
Action: opened

PR body:
"""
This PR was opened automatically because PR #1948 was pushed to master and 
backport to ipa-4-6 is required.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1955/head:pr1955
git checkout pr1955
From 43a8787b8cc6266e5d30ba93a2019df76ece49f8 Mon Sep 17 00:00:00 2001
From: amitkumar50 <amitk...@redhat.com>
Date: Sun, 20 May 2018 10:43:00 +0530
Subject: [PATCH] ipa vault-archive overwrites an existing value without
 warning

Upstream ticket was raised for issuing an warning message
whenever data in ipa vault is overwritten.

In Bugzilla(1339129) its agreed upon that Current behavior is consistent
with other IPA commands. None of ipa mod commands asks for confirmation
and therefore it should be the same here.
But to document, that vault can contain only one value in ipa help vault.

This PR addresses the changes agreed in Bugzilla.

Resolves: https://pagure.io/freeipa/issue/5922
---
 ipaserver/plugins/vault.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ipaserver/plugins/vault.py b/ipaserver/plugins/vault.py
index 135a51846d..682f6bea74 100644
--- a/ipaserver/plugins/vault.py
+++ b/ipaserver/plugins/vault.py
@@ -55,7 +55,9 @@
 """) + _("""
 Manage vaults.
 """) + _("""
-Vault is a secure place to store a secret.
+Vault is a secure place to store a secret. One vault can only
+store one secret. When archiving a secret in a vault, the
+existing secret (if any) is overwritten.
 """) + _("""
 Based on the ownership there are three vault categories:
 * user/private vault
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/4SYV5OCBFJZMQIWWXDPWIKR6G3HAJVI2/

Reply via email to