URL: https://github.com/freeipa/freeipa/pull/2088 Author: tiran Title: #2088: Catch ACIError instead of invalid credentials Action: opened
PR body: """ ipaldap's LDAPClient client turns INVALID_CREDENTIAL error into ACIError. Catch the ACIError and wait until the user has been replicated. Apparently no manual or automated test ran into the timeout during testing. Fixes: Fixes: https://pagure.io/freeipa/issue/7593 Signed-off-by: Christian Heimes <chei...@redhat.com> Manual backport of PR #2084 to 4.5 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/2088/head:pr2088 git checkout pr2088
From 0221e5e649245df48e5848ca16189a52a029efe9 Mon Sep 17 00:00:00 2001 From: Christian Heimes <chei...@redhat.com> Date: Fri, 29 Jun 2018 11:08:45 +0200 Subject: [PATCH] Catch ACIError instead of invalid credentials ipaldap's LDAPClient client turns INVALID_CREDENTIAL error into ACIError. Catch the ACIError and wait until the user has been replicated. Apparently no manual or automated test ran into the timeout during testing. Fixes: Fixes: https://pagure.io/freeipa/issue/7593 Signed-off-by: Christian Heimes <chei...@redhat.com> --- ipaserver/install/dogtaginstance.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ipaserver/install/dogtaginstance.py b/ipaserver/install/dogtaginstance.py index 960b8cc7ce..1f9742b287 100644 --- a/ipaserver/install/dogtaginstance.py +++ b/ipaserver/install/dogtaginstance.py @@ -468,7 +468,8 @@ def setup_admin(self): time.sleep(1) try: master_conn.simple_bind(self.admin_dn, self.admin_password) - except ldap.INVALID_CREDENTIALS: + except errors.ACIError: + # user not replicated yet pass else: self.log.debug("Successfully logged in as %s", self.admin_dn)
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/M66DXBOFCYL3W4SCACLLCYAVCK3TGVEY/
