URL: https://github.com/freeipa/freeipa/pull/2113 Author: flo-renaud Title: #2113: ipa client uninstall: clean the state store when restoring hostname Action: opened
PR body: """ When ipa client was installed with the --hostname= option, it stores [network] hostname = (current hostname) in /var/lib/ipa-client/sysrestore/sysrestore.state and changes the hostname from (current hostname) to the value provided in --hostname. During uninstall, the previous hostname is restored but the entry does not get removed from sysrestore.state. As the uninstaller checks if all entries from sysrestore.state have been restored, it warns that some state has not been restored. The fix calls statestore.restore_state() instead of statestore.get_state() as this method also clears the entry. https://pagure.io/freeipa/issue/7620 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/2113/head:pr2113 git checkout pr2113
From ae790d33bbe0c8c9ab5fe532003015ed19de1feb Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Fri, 6 Jul 2018 12:47:34 +0200 Subject: [PATCH] ipa client uninstall: clean the state store when restoring hostname When ipa client was installed with the --hostname= option, it stores [network] hostname = (current hostname) in /var/lib/ipa-client/sysrestore/sysrestore.state and changes the hostname from (current hostname) to the value provided in --hostname. During uninstall, the previous hostname is restored but the entry does not get removed from sysrestore.state. As the uninstaller checks if all entries from sysrestore.state have been restored, it warns that some state has not been restored. The fix calls statestore.restore_state() instead of statestore.get_state() as this method also clears the entry. https://pagure.io/freeipa/issue/7620 --- ipaplatform/redhat/tasks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaplatform/redhat/tasks.py b/ipaplatform/redhat/tasks.py index 237681c0f3..6f725dbdb4 100644 --- a/ipaplatform/redhat/tasks.py +++ b/ipaplatform/redhat/tasks.py @@ -392,7 +392,7 @@ def backup_hostname(self, fstore, statestore): statestore.backup_state('network', 'hostname', old_hostname) def restore_hostname(self, fstore, statestore): - old_hostname = statestore.get_state('network', 'hostname') + old_hostname = statestore.restore_state('network', 'hostname') if old_hostname is not None: try:
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/TOVU6YGY3KVHJQOUZYM3INFV7NBM3FLA/
