URL: https://github.com/freeipa/freeipa/pull/2651 Author: Tiboris Title: #2651: [Backport][ipa-4-7] Test error when yubikey hardware not present Action: opened
PR body: """ This PR was opened automatically because PR #2306 was pushed to master and backport to ipa-4-7 is required. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/2651/head:pr2651 git checkout pr2651
From 8f51d52e47a70b29761c1043e3b215e122e32b7f Mon Sep 17 00:00:00 2001 From: Mohammad Rizwan Yusuf <myu...@redhat.com> Date: Thu, 30 Aug 2018 16:07:33 +0530 Subject: [PATCH] Test error when yubikey hardware not present In order to work with IPA and Yubikey, libyubikey is required. Before the fix, if yubikey added without having packages, it used to result in traceback. Now it the exception is handeled properly. It needs Yubikey hardware to make command successfull. This test just check of proper error thrown when hardware is not attached. related ticket : https://pagure.io/freeipa/issue/6979 Signed-off-by: Mohammad Rizwan Yusuf <myu...@redhat.com> --- ipatests/test_integration/test_installation.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/ipatests/test_integration/test_installation.py b/ipatests/test_integration/test_installation.py index 3be6150e48..fcfee8827f 100644 --- a/ipatests/test_integration/test_installation.py +++ b/ipatests/test_integration/test_installation.py @@ -432,6 +432,24 @@ def test_WSGI_worker_process(self): wsgi_count = cmd.stdout_text.count('wsgi:ipa') assert constants.WSGI_PROCESSES == wsgi_count + def test_error_for_yubikey(self): + """ Test error when yubikey hardware not present + + In order to work with IPA and Yubikey, libyubikey is required. + Before the fix, if yubikey added without having packages, it used to + result in traceback. Now it the exception is handeled properly. + It needs Yubikey hardware to make command successfull. This test + just check of proper error thrown when hardware is not attached. + + related ticket : https://pagure.io/freeipa/issue/6979 + """ + # try to add yubikey to the user + args = ['ipa', 'otptoken-add-yubikey', '--owner=admin'] + cmd = self.master.run_command(args, raiseonerr=False) + assert cmd.returncode != 0 + exp_str = ("ipa: ERROR: No YubiKey found") + assert exp_str in cmd.stderr_text + class TestInstallMasterKRA(IntegrationTest):
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org