URL: https://github.com/freeipa/freeipa/pull/3096
Author: tiran
Title: #3096: Import urllib submodules
Action: opened
PR body:
"""
otpclient only imported the urllib parent package, not urllib.request
and urllib.parse subpackages. This may or may not work depending on the
import order of other plugins.
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3096/head:pr3096
git checkout pr3096
From f9b81a7bb639b78c217f9f1b3fae3082180cc5ff Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Mon, 29 Apr 2019 17:51:09 +0200
Subject: [PATCH] Import urllib submodules
otpclient only imported the urllib parent package, not urllib.request
and urllib.parse subpackages. This may or may not work depending on the
import order of other plugins.
Signed-off-by: Christian Heimes <chei...@redhat.com>
---
ipaclient/plugins/otptoken.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ipaclient/plugins/otptoken.py b/ipaclient/plugins/otptoken.py
index 0f3c6f8659..92b8780f2a 100644
--- a/ipaclient/plugins/otptoken.py
+++ b/ipaclient/plugins/otptoken.py
@@ -34,7 +34,8 @@
import six
from io import StringIO
-import urllib
+import urllib.parse
+import urllib.request
if six.PY3:
unicode = str
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
