URL: https://github.com/freeipa/freeipa/pull/3334 Author: amore17 Title: #3334: ipatests: POSIX attributes are no longer overwritten or missing Action: opened
PR body: """ Added test which validates that POSIX attributes, such as shell or home directory, are no longer overwritten or missing. Related Ticket : https://pagure.io/SSSD/sssd/issue/2474 Signed-off-by: Anuja More <am...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/3334/head:pr3334 git checkout pr3334
From 584ad50cde74984bc51e317c2d0df0ff18e4e12b Mon Sep 17 00:00:00 2001 From: Anuja More <am...@redhat.com> Date: Mon, 24 Jun 2019 19:57:59 +0530 Subject: [PATCH] ipatests: POSIX attributes are no longer overwritten or missing Added test which validates that POSIX attributes, such as shell or home directory, are no longer overwritten or missing. Related Ticket : https://pagure.io/SSSD/sssd/issue/2474 Signed-off-by: Anuja More <am...@redhat.com> --- ipatests/test_integration/test_trust.py | 46 ++++++++++++++++++++++++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_trust.py b/ipatests/test_integration/test_trust.py index cd13cfa4cc..c591809aa3 100644 --- a/ipatests/test_integration/test_trust.py +++ b/ipatests/test_integration/test_trust.py @@ -6,6 +6,7 @@ import unittest from ipaplatform.constants import constants as platformconstants +from ipaplatform.paths import paths from ipatests.test_integration.base import IntegrationTest from ipatests.pytest_ipa.integration import tasks @@ -48,7 +49,6 @@ def install(cls, mh): '_ldap._tcp.Default-First-Site-Name._sites.gc._msdcs' cls.srv_gc_record_value = '0 100 389 {}.'.format(cls.master.hostname) - @classmethod def check_sid_generation(cls): command = ['ipa', 'user-show', 'admin', '--all', '--raw'] @@ -223,6 +223,50 @@ def test_user_without_posix_attributes_not_visible(self): # Getent exits with 2 for non-existent user assert result.returncode == 2 + def test_override_homedir(self): + """POSIX attributes should not be overwritten or missing. + + Regression test for bug https://pagure.io/SSSD/sssd/issue/2474 + + When there is IPA-AD trust with POSIX attributes, + including the home directory set in the AD LDAP and in sssd.conf + subdomain_homedir = %o is added after initgroup call home directory + should be correct and do not report in logs like, + 'get_subdomain_homedir_of_user failed: * [Home directory is NULL]' + """ + tasks.backup_file(self.master, paths.SSSD_CONF) + log_file = '{0}/sssd_{1}.log' .format(paths.VAR_LOG_SSSD_DIR, + self.master.domain.name) + + logsize = len(self.master.get_file_contents(log_file)) + + try: + testuser = 'testuser@%s' % self.ad_domain + domain = self.master.domain + tasks.modify_sssd_conf( + self.master, + domain.name, + { + 'subdomain_homedir': '%o' + } + ) + + tasks.clear_sssd_cache(self.master) + # The initgroups operation now uses the LDAP connection because + # the LDAP AD DS server contains the POSIX attributes + self.master.run_command(['getent', 'initgroups', '-s', 'sss', + testuser]) + + result = self.master.run_command(['getent', 'passwd', testuser]) + assert '/home/testuser' in result.stdout_text + + sssd_log2 = self.master.get_file_contents(log_file)[logsize:] + + assert b'get_subdomain_homedir_of_user failed' not in sssd_log2 + finally: + tasks.restore_files(self.master) + tasks.clear_sssd_cache(self.master) + def test_remove_posix_trust(self): self.remove_trust(self.ad)
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
