URL: https://github.com/freeipa/freeipa/pull/4127 Author: flo-renaud Title: #4127: ipa tests: fix backup and restore Action: opened
PR body: """ The tests for backup_and_restore check that the ipa-backup command compresses the tar file AFTER restarting IPA services by reading the output and looking for a pattern with "gzip" before "Starting IPA service." As the tar file name is randomly created, it sometimes happen that the name contains gzip and in this case the test wrongly assumes that the gzip cmd was called. The fix makes a stricter comparison, looking for /bin/gzip. Fixes: https://pagure.io/freeipa/issue/8170 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4127/head:pr4127 git checkout pr4127
From 285b6d276e1c3e892203b1277bccba44f08e9ef9 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Tue, 14 Jan 2020 13:52:49 +0100 Subject: [PATCH 1/2] ipatests: fix backup and restore The tests for backup_and_restore check that the ipa-backup command compresses the tar file AFTER restarting IPA services by reading the output and looking for a pattern with "gzip" before "Starting IPA service." As the tar file name is randomly created, it sometimes happen that the name contains gzip and in this case the test wrongly assumes that the gzip cmd was called. The fix makes a stricter comparison, looking for /bin/gzip. Fixes: https://pagure.io/freeipa/issue/8170 --- ipatests/test_integration/test_backup_and_restore.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_backup_and_restore.py b/ipatests/test_integration/test_backup_and_restore.py index a43f8f9e84..dbe44ff22c 100644 --- a/ipatests/test_integration/test_backup_and_restore.py +++ b/ipatests/test_integration/test_backup_and_restore.py @@ -165,7 +165,7 @@ def backup(host): # Test for ticket 7632: check that services are restarted # before the backup is compressed - pattern = r'.*gzip.*Starting IPA service.*' + pattern = r'.*{}.*Starting IPA service.*'.format(paths.GZIP) if (re.match(pattern, result.stderr_text, re.DOTALL)): raise AssertionError('IPA Services are started after compression') From 163f47fe3f2e571e330768e1a75633d178da3f56 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Tue, 14 Jan 2020 14:03:30 +0100 Subject: [PATCH 2/2] temp commit - please remove before pushing --- .freeipa-pr-ci.yaml | 2 +- ipatests/prci_definitions/temp_commit.yaml | 16 +++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml index abcf8c5b63..8065669008 120000 --- a/.freeipa-pr-ci.yaml +++ b/.freeipa-pr-ci.yaml @@ -1 +1 @@ -ipatests/prci_definitions/gating.yaml \ No newline at end of file +ipatests/prci_definitions/temp_commit.yaml \ No newline at end of file diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml index 5afbe014f9..179ceb69bf 100644 --- a/ipatests/prci_definitions/temp_commit.yaml +++ b/ipatests/prci_definitions/temp_commit.yaml @@ -57,14 +57,16 @@ jobs: timeout: 1800 topology: *build - fedora-latest/temp_commit: - requires: [fedora-latest/build] + testing-fedora/test_backup_and_restore_TestBackupReinstallRestoreWithDNS: + requires: [testing-fedora/build] priority: 50 job: class: RunPytest args: - build_url: '{fedora-latest/build_url}' - test_suite: test_integration/test_REPLACEME.py - template: *ci-master-latest - timeout: 3600 - topology: *master_1repl_1client + build_url: '{testing-fedora/build_url}' + update_packages: True + test_suite: test_integration/test_backup_and_restore.py::TestBackupReinstallRestoreWithDNS + template: *testing-master-latest + timeout: 7200 + topology: *master_1repl +
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
