URL: https://github.com/freeipa/freeipa/pull/4250 Author: abbra Title: #4250: [Backport][ipa-4-8] kdb: make sure audit_as_req callback signature change is preserved Action: opened
PR body: """ This PR was opened automatically because PR #4249 was pushed to master and backport to ipa-4-8 is required. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4250/head:pr4250 git checkout pr4250
From 7debf95ec13ebfc4d335b7d058fa7121897f548b Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy <[email protected]> Date: Mon, 17 Feb 2020 13:58:51 +0200 Subject: [PATCH 1/2] kdb: make sure audit_as_req callback signature change is preserved audit_as_req() callback has changed its signature with MIT krb5 commit 20991d55efbe1f987c1dbc1065f2d58c8f34031b in 2017, we should preserve the change for any newer DAL versions. Otherwise audit_as_req() callback would reference wrong data and we might crash. Fixes: https://pagure.io/freeipa/issue/8200 Signed-off-by: Alexander Bokovoy <[email protected]> --- daemons/ipa-kdb/ipa_kdb.h | 2 +- daemons/ipa-kdb/ipa_kdb_audit_as.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-kdb/ipa_kdb.h b/daemons/ipa-kdb/ipa_kdb.h index 7519f26e26..ae37a5a033 100644 --- a/daemons/ipa-kdb/ipa_kdb.h +++ b/daemons/ipa-kdb/ipa_kdb.h @@ -345,7 +345,7 @@ krb5_error_code ipadb_check_allowed_to_delegate(krb5_context kcontext, void ipadb_audit_as_req(krb5_context kcontext, krb5_kdc_req *request, -#if (KRB5_KDB_DAL_MAJOR_VERSION == 7) +#if (KRB5_KDB_DAL_MAJOR_VERSION >= 7) const krb5_address *local_addr, const krb5_address *remote_addr, #endif diff --git a/daemons/ipa-kdb/ipa_kdb_audit_as.c b/daemons/ipa-kdb/ipa_kdb_audit_as.c index 77748a75d6..a60bc82b6d 100644 --- a/daemons/ipa-kdb/ipa_kdb_audit_as.c +++ b/daemons/ipa-kdb/ipa_kdb_audit_as.c @@ -25,7 +25,7 @@ void ipadb_audit_as_req(krb5_context kcontext, krb5_kdc_req *request, -#if (KRB5_KDB_DAL_MAJOR_VERSION == 7) +#if (KRB5_KDB_DAL_MAJOR_VERSION >= 7) const krb5_address *local_addr, const krb5_address *remote_addr, #endif From 6b5dc418f92b5f14987568ba774725dd0bba5a73 Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy <[email protected]> Date: Mon, 17 Feb 2020 14:21:10 +0200 Subject: [PATCH 2/2] Azure Pipelines: re-enable nodejs:12 stream for Fedora 31+ --- ipatests/azure/templates/prepare-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/ipatests/azure/templates/prepare-build.yml b/ipatests/azure/templates/prepare-build.yml index 0528efe129..643910f085 100644 --- a/ipatests/azure/templates/prepare-build.yml +++ b/ipatests/azure/templates/prepare-build.yml @@ -13,6 +13,7 @@ steps: for metalink in $(sudo dnf repolist -v |grep Repo-metalink | awk '{print $2}' ) ; do echo '###############' ; echo '####' ; echo $metalink ; echo '####' ; curl $metalink ; done echo "Fastestmirror results:" sudo cat /var/cache/dnf/fastestmirror.cache + sudo dnf -y module enable nodejs:12 sudo dnf makecache || : echo "Installing base development environment" sudo dnf install -y \
_______________________________________________ FreeIPA-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected]
