URL: https://github.com/freeipa/freeipa/pull/4947
Author: fcami
Title: #4947: ipatests: test_commands: test_login_wrong_password: look farther
in time
Action: opened
PR body:
"""
Sometimes test_login_wrong_password fails because the log window the
string message is searched in is too narrow.
Broaden the window by looking at the past 10 seconds.
Fixes: https://pagure.io/freeipa/issue/8432
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/4947/head:pr4947
git checkout pr4947
From 39c6a24264f7a30e3326d45cddcfa59708278a89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fc...@redhat.com>
Date: Mon, 27 Jul 2020 17:22:46 +0200
Subject: [PATCH 1/2] ipatests: test_commands: test_login_wrong_password: look
farther in time
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sometimes test_login_wrong_password fails because the log window the
string message is searched in is too narrow.
Broaden the window by looking at the past 10 seconds.
Fixes: https://pagure.io/freeipa/issue/8432
Signed-off-by: François Cami <fc...@redhat.com>
---
ipatests/test_integration/test_commands.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/ipatests/test_integration/test_commands.py b/ipatests/test_integration/test_commands.py
index bacde50416..d930f1e235 100644
--- a/ipatests/test_integration/test_commands.py
+++ b/ipatests/test_integration/test_commands.py
@@ -20,6 +20,7 @@
from cryptography.hazmat.backends import default_backend
from cryptography import x509
+from datetime import datetime, timedelta
from ipalib.constants import IPAAPI_USER
@@ -1202,7 +1203,11 @@ def test_login_wrong_password(self, user_creation_deletion):
sshconn = paramiko.SSHClient()
sshconn.set_missing_host_key_policy(paramiko.AutoAddPolicy())
- since = time.strftime('%H:%M:%S')
+ # start to look at logs a bit before "now"
+ # https://pagure.io/freeipa/issue/8432
+ since = time.strftime(
+ '%H:%M:%S', (datetime.now() - timedelta(seconds=10)).timetuple()
+ )
try:
sshconn.connect(self.master.hostname,
username=self.testuser,
From 5418cabc3583aa54b65d538f08718f70e16c4907 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fc...@redhat.com>
Date: Thu, 23 Jul 2020 18:19:04 +0200
Subject: [PATCH 2/2] temp commit
---
.freeipa-pr-ci.yaml | 2 +-
ipatests/prci_definitions/temp_commit.yaml | 7 ++++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml
index abcf8c5b63..8065669008 120000
--- a/.freeipa-pr-ci.yaml
+++ b/.freeipa-pr-ci.yaml
@@ -1 +1 @@
-ipatests/prci_definitions/gating.yaml
\ No newline at end of file
+ipatests/prci_definitions/temp_commit.yaml
\ No newline at end of file
diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml
index e337068145..c161f635b2 100644
--- a/ipatests/prci_definitions/temp_commit.yaml
+++ b/ipatests/prci_definitions/temp_commit.yaml
@@ -61,14 +61,15 @@ jobs:
timeout: 1800
topology: *build
- fedora-latest/temp_commit:
+ fedora-latest/test_commands:
requires: [fedora-latest/build]
priority: 50
job:
class: RunPytest
args:
build_url: '{fedora-latest/build_url}'
- test_suite: test_integration/test_REPLACEME.py
+ test_suite: test_integration/test_commands.py
template: *ci-master-latest
timeout: 3600
- topology: *master_1repl_1client
+ topology: *master_1repl
+
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
