URL: https://github.com/freeipa/freeipa/pull/4971
Author: rcritten
 Title: #4971: [Backport][ipa-4-8] Fix for two failing healthcheck tests
Action: opened

PR body:
"""
This PR was opened automatically because PR #4943 was pushed to master and 
backport to ipa-4-8 is required.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/4971/head:pr4971
git checkout pr4971
From 632c3b216945705df436dd22db4fb4bca0fe9981 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcrit...@redhat.com>
Date: Wed, 22 Jul 2020 11:47:23 -0400
Subject: [PATCH 1/2] ipatests: lib389 is now providing healthchecks, update
 naming

---
 ipatests/test_integration/test_ipahealthcheck.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py
index 102b7397e1..748b09912e 100644
--- a/ipatests/test_integration/test_ipahealthcheck.py
+++ b/ipatests/test_integration/test_ipahealthcheck.py
@@ -93,7 +93,7 @@
 ipafiles_checks = ["IPAFileNSSDBCheck", "IPAFileCheck", "TomcatFileCheck"]
 dogtag_checks = ["DogtagCertsConfigCheck", "DogtagCertsConnectivityCheck"]
 iparoles_checks = ["IPACRLManagerCheck", "IPARenewalMasterCheck"]
-replication_checks = ["ReplicationConflictCheck"]
+replication_checks = ["ReplicationCheck"]
 ruv_checks = ["RUVCheck"]
 dna_checks = ["IPADNARangeCheck"]
 idns_checks = ["IPADNSSystemRecordsCheck"]

From 4f275422e42b2ca5fb9d98c59636024ad8b7c6c4 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcrit...@redhat.com>
Date: Fri, 24 Jul 2020 10:09:35 -0400
Subject: [PATCH 2/2] ipatests: Use healthcheck namespacing in stopped server
 test

The test_run_with_stopped_master() test runs ipactl stop
and then verifies that all the errors relate to the services
not being available. The newly integrated PKI tests also
report errors in this case.

Use the namespacing introduced in freeipa-healthcheck-0.6
to limit the execution to the ipahealthcheck.meta checks
to avoid the spurious PKI errors.

Signed-off-by: Rob Crittenden <rcrit...@redhat.com>
---
 ipatests/test_integration/test_ipahealthcheck.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py
index 748b09912e..7818cab3eb 100644
--- a/ipatests/test_integration/test_ipahealthcheck.py
+++ b/ipatests/test_integration/test_ipahealthcheck.py
@@ -689,6 +689,7 @@ def test_run_with_stopped_master(self, ipactl):
         """
         returncode, output = run_healthcheck(
             self.master,
+            "ipahealthcheck.meta",
             output_type="human",
             failures_only=True)
         assert returncode == 1
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org

Reply via email to