URL: https://github.com/freeipa/freeipa/pull/4982 Author: stanislavlevin Title: #4982: pylint: Fix warning and error Action: opened
PR body: """ - fixed W0612(unused-variable) - added missing dependency on python-yaml Fixes: https://pagure.io/freeipa/issue/8442 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4982/head:pr4982 git checkout pr4982
From f7bc4e9ff5adc76d97fcad18867ee76911525b54 Mon Sep 17 00:00:00 2001 From: Stanislav Levin <s...@altlinux.org> Date: Tue, 4 Aug 2020 12:41:11 +0300 Subject: [PATCH] pylint: Fix warning and error - fixed W0612(unused-variable) - added missing dependency on python-yaml Fixes: https://pagure.io/freeipa/issue/8442 Signed-off-by: Stanislav Levin <s...@altlinux.org> --- freeipa.spec.in | 1 + ipaserver/install/httpinstance.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index b11a5225c0..4cea29afdf 100755 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -302,6 +302,7 @@ BuildRequires: python3-sss BuildRequires: python3-sss-murmur BuildRequires: python3-sssdconfig >= %{sssd_version} BuildRequires: python3-systemd +BuildRequires: python3-yaml BuildRequires: python3-yubico # with_lint %endif diff --git a/ipaserver/install/httpinstance.py b/ipaserver/install/httpinstance.py index cfbd8ca765..0fcc370e5e 100644 --- a/ipaserver/install/httpinstance.py +++ b/ipaserver/install/httpinstance.py @@ -394,7 +394,7 @@ def __setup_ssl(self): ) try: certmonger.request_and_wait_for_cert(**args) - except Exception as e: + except Exception: args['dns'] = [self.fqdn] # remove ipa-ca.$DOMAIN args['stop_tracking_on_error'] = False certmonger.request_and_wait_for_cert(**args)
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org