URL: https://github.com/freeipa/freeipa/pull/4984 Author: flo-renaud Title: #4984: ipatests: fix test_ipahealthcheck.py::TestIpaHealthCheck Action: opened
PR body: """ test_ipa_healthcheck_expiring is assuming that it's executed on a KRA-less installation, but the test is executed after test_ipa_healthcheck_no_errors that configures the KRA. With a KRA install, 12 certs are monitored instead of 9. Fixes: https://pagure.io/freeipa/issue/8439 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4984/head:pr4984 git checkout pr4984
From 207cf7ac741428adbefceac2ffdb173950f81a18 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Tue, 4 Aug 2020 14:59:58 +0200 Subject: [PATCH 1/2] ipatests: fix test_ipahealthcheck.py::TestIpaHealthCheck test_ipa_healthcheck_expiring is assuming that it's executed on a KRA-less installation, but the test is executed after test_ipa_healthcheck_no_errors that configures the KRA. With a KRA install, 12 certs are monitored instead of 9. Fixes: https://pagure.io/freeipa/issue/8439 --- ipatests/test_integration/test_ipahealthcheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py index 7818cab3eb..6adb6c463b 100644 --- a/ipatests/test_integration/test_ipahealthcheck.py +++ b/ipatests/test_integration/test_ipahealthcheck.py @@ -799,7 +799,7 @@ def execute_expiring_check(check): ) assert returncode == 1 - assert len(data) == 9 # non-KRA is 9 tracked certs + assert len(data) == 12 # KRA is 12 tracked certs for check in data: if check["result"] == "SUCCESS": From af1c702889378e9a92b5ff9ce9f133065b788300 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Tue, 4 Aug 2020 15:03:05 +0200 Subject: [PATCH 2/2] Temp commit --- .freeipa-pr-ci.yaml | 2 +- ipatests/prci_definitions/temp_commit.yaml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml index abcf8c5b63..8065669008 120000 --- a/.freeipa-pr-ci.yaml +++ b/.freeipa-pr-ci.yaml @@ -1 +1 @@ -ipatests/prci_definitions/gating.yaml \ No newline at end of file +ipatests/prci_definitions/temp_commit.yaml \ No newline at end of file diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml index e337068145..e72fb7ad7a 100644 --- a/ipatests/prci_definitions/temp_commit.yaml +++ b/ipatests/prci_definitions/temp_commit.yaml @@ -61,14 +61,14 @@ jobs: timeout: 1800 topology: *build - fedora-latest/temp_commit: + fedora-latest/test_ipahealthcheck: requires: [fedora-latest/build] priority: 50 job: class: RunPytest args: build_url: '{fedora-latest/build_url}' - test_suite: test_integration/test_REPLACEME.py + test_suite: test_integration/test_ipahealthcheck.py::TestIpaHealthCheck template: *ci-master-latest - timeout: 3600 - topology: *master_1repl_1client + timeout: 4800 + topology: *master_1repl
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
