URL: https://github.com/freeipa/freeipa/pull/5234
Author: flo-renaud
 Title: #5234: [Backport][ipa-4-8] ipatests: Fix for 
test_ipahealthcheck_ds_encryption
Action: opened

PR body:
"""
This is a manual backport of PR #5221 to ipa-4-8 branch.

Auto-ACKed as this is a trivial backport
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/5234/head:pr5234
git checkout pr5234
From 03b077ce42048a91f342aafd336636d147b45262 Mon Sep 17 00:00:00 2001
From: Florence Blanc-Renaud <f...@redhat.com>
Date: Fri, 6 Nov 2020 16:03:54 +0100
Subject: [PATCH] ipatests: Fix for test_ipahealthcheck_ds_encryption

Nightly test failure was seen for test_ipahealthcheck_ds_encryption
The test was failing since @pytest.fixture was not specified before
the function modify_tls

Ref: https://pagure.io/freeipa/issue/8560
Reviewed-By: Mohammad Rizwan Yusuf <myu...@redhat.com>
Reviewed-By: Florence Blanc-Renaud <f...@redhat.com>
---
 ipatests/test_integration/test_ipahealthcheck.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py
index 1dcd4e277dd..dc6d30a835f 100644
--- a/ipatests/test_integration/test_ipahealthcheck.py
+++ b/ipatests/test_integration/test_ipahealthcheck.py
@@ -1043,9 +1043,10 @@ def test_ipahealthcheck_ds_riplugincheck(self, update_riplugin):
             assert check["result"] == "WARNING"
             assert warn_msg in check["kw"]["msg"]
 
+    @pytest.fixture
     def modify_tls(self, restart_service):
         """
-        Modify DS tls version to TLS1.0 using dsconf tool and
+        Fixture to modify DS tls version to TLS1.0 using dsconf tool and
         revert back to the default TLS1.2
         """
         instance = realm_to_serverid(self.master.domain.realm)
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org

Reply via email to